Repository navigation
Conversation
Kodi's settings window has a help area for the focused setting, but the old settings format can't fill it, so it always said "No information available" and every explanation had to fit in the label. Skins such as Arctic Fuse 3 cut those long labels off (#395). settings.xml now uses the version 1 format. Setting ids, types, defaults and ranges are unchanged, so saved values carry over. The test buttons get ids of their own, which the new format needs. - Every setting has a help string (30900-30923). Binge mode's grey note (30651) is now its help text. - Long English labels are shortened (14 of them). Other languages keep their current text under the new msgid until translators shorten it; French is shortened here, since it's the language from the report. - The "still watching" settings are grouped under "Are you still watching?" (30653). The countdown and skip separators become group labels. - The "eq(-N,false)" offsets become named dependencies on bingeMode, selectOpensPlaybackControls, bedtimeEnabled, customAutoPlayTime and enableSkipSegments. tests/test_settings.py checks the new file: every setting has an English label and help, labels stay short, dependencies and parents name real settings, and every setting the code reads exists. Fixes #395 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Low impact] The PR appears safe to merge, with the previous test-coverage gap fixed. SummaryMoves settings to Kodi’s current format, adds help text, and shortens labels.
Reviews (2) · Last reviewed commit: "Check the auto-skip settings read throug..." · Reviewed by Greptile |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for your work, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #395.
Kodi's settings window has a help area for the focused setting. Up Next's settings used the old format, which can't fill it, so it always said "No information available" and every explanation had to fit in the label. Skins such as Arctic Fuse 3 cut those long labels off.
Change
settings.xmlnow uses Kodi's version 1 settings format (supported since Kodi 19). Setting ids, types, defaults and ranges are unchanged, so saved values carry over. The five developer test buttons get ids, which the new format needs.eq(-N,false)row offsets become named dependencies (onbingeMode,selectOpensPlaybackControls,bedtimeEnabled,customAutoPlayTime,enableSkipSegments).Translations
msgcmpstill matches.[COLOR gray]tags in every language, since it's help text now.Tested in Kodi 21.3 (macOS)
Tests: tests/test_settings.py checks the new format:
The Binge mode tests now check named dependencies. 499 tests pass locally, and pylint and flake8 are clean.
🤖 Generated with Claude Code